Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Black dependency to fix CI lint #900

Merged
merged 2 commits into from Mar 31, 2022

Conversation

intgr
Copy link
Collaborator

@intgr intgr commented Mar 30, 2022

Closes #896.

Black 22.3.0 fixes incompatibility with Click 8.1.0: psf/black#2966

This currently causes the CI to fail, e.g. https://github.com/typeddjango/django-stubs/runs/5756075543

Closes typeddjango#896.

Black 22.3.0 fixes incompatibility with Click 8.1.0:
psf/black#2966

This currently causes the CI to fail, e.g. https://github.com/typeddjango/django-stubs/runs/5756075543
@@ -28,7 +28,7 @@ repos:
types: [pyi]
args: ["--profile", "black"]
- repo: https://github.com/psf/black
rev: 21.12b0
rev: 22.3.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like .pre-commit-config.yaml hasn't been kept in sync with requirements.txt as it should be.

@intgr
Copy link
Collaborator Author

intgr commented Mar 30, 2022

I'm not sure why it's still failing, but it's a different message this time.

@sobolevn
Copy link
Member

You need to reformat some files with new black version.

@intgr
Copy link
Collaborator Author

intgr commented Mar 30, 2022

Ahh! Makes sense, I will do it tomorrow.

@intgr
Copy link
Collaborator Author

intgr commented Mar 31, 2022

Fixed, should be ready to merge now.

@sobolevn sobolevn merged commit 212ef40 into typeddjango:master Mar 31, 2022
@sobolevn
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants