Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable monkeypatches, add dependencies via new hook #60

Merged
merged 11 commits into from Apr 12, 2019
Merged

Disable monkeypatches, add dependencies via new hook #60

merged 11 commits into from Apr 12, 2019

Conversation

mkurnikov
Copy link
Member

@mkurnikov mkurnikov commented Mar 28, 2019 •
edited

This was referenced Mar 28, 2019
Merged
Closed
@syastrov
Copy link
Contributor

Mypy 0.700 is out, I guess it can be merged now?

@mkurnikov
Copy link
Member Author

@syastrov Tests are faster now, so I split queryset.test file tests into a number of smaller ones. Also made some lookups.py code less dense. I should've been that lazy when I reviewed it, sorry for that.

Hope it won't discourage you from contributing.

@mkurnikov mkurnikov merged commit aeb435c into master Apr 12, 2019
@sobolevn sobolevn deleted the add-deps-using-new-hook branch August 30, 2019 08:18
@TonyRippy TonyRippy mentioned this pull request Dec 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyError: 'django.conf.global_settings'
2 participants
@mkurnikov @syastrov