Restore inner class Meta in models where it is accessible
#2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that the inner `Meta` class is accessible for some models, but not others. Added `class Meta` only to stub model classes where it's accessible from outside (e.g. `AbstractBaseUser.Meta` does not crash with AttributeError).
sobolevn
reviewed
May 17, 2024
There was a problem hiding this comment.
Oh, I am lost! :)
So, what will happen now if we inherit some model with existing Meta and create our own Meta?
Can we:
- Inherit
Metaas well as inclass MyModel(SomeModel): class Meta(SomeModel.Meta)? - Or do we have to use
# type: ignore? - Can we use
.Metaon these types?
Do we need to test any of these?
| class Meta: | ||
| verbose_name: str | ||
| verbose_name_plural: str | ||
| abstract: bool |
There was a problem hiding this comment.
I think using Literal[True] here won't help anyone, to the contrary.
If the user subclasses this Meta and sets abstract = False, mypy will consider that a type error since it's not True. But it would be perfectly legal usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Turns out that the inner
Metaclass is accessible for some models, but not others. Addedclass Metaonly to stub model classes where it's accessible from outside (e.g.AbstractBaseUser.Metadoes not crash with AttributeError). Used a hacky script at https://gist.github.com/intgr/352cac61b4f95e921bb33a0d4b76d324. See #2112 (comment) for details.Related issues
class MetafromModelandFormclass stubs #2000