Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0: Update django.db.models.field.related_descriptors #2157

Merged
merged 2 commits into from
May 21, 2024

Conversation

saJaeHyukc
Copy link
Contributor

I have made things!

Update stubs for django.db.models.field.related_descriptors for Django 5.0.

  • django.db.models.fields.related_descriptors
    • django.db.models.fields.related_descriptors.ForwardManyToOneDescriptor.get_prefetch_querysets was added
    • django.db.models.fields.related_descriptors.ReverseOneToOneDescriptor.get_prefetch_querysets was added

Related issues

Refs

Upstream PR

@saJaeHyukc saJaeHyukc mentioned this pull request May 13, 2024
39 tasks
@sobolevn
Copy link
Member

@saJaeHyukc please, rebase :)

@saJaeHyukc
Copy link
Contributor Author

@saJaeHyukc please, rebase :)

Applied as you mentioned :)

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can work on annotations later to remove Any, it requires quite a lot of effort from both contributor and reviewer.

@sobolevn sobolevn merged commit e5bda21 into typeddjango:master May 21, 2024
36 checks passed
@saJaeHyukc
Copy link
Contributor Author

We can work on annotations later to remove Any, it requires quite a lot of effort from both contributor and reviewer.

I agree with the handling of 'Any'. I will continue to work on it as much as possible, but even if I am busy, I will actively help whenever I can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants