[ChaCha] speed improvement and spec conformance #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vincenthz
commented
Mar 3, 2023
•
vincenthz
commented
- Improve ref speed by 10x removing the use of (fake) simd on chacha
- improve ref speed by 3x on salsa
- Clearly separate the bernstein/original version from the IETF standard version in term of counters size and nonce handling
- Separate XChaCha from the 'normal' ChaCha context
- Separate XSalsa from the 'normal' Salsa context
* Improve ref speed by 10x removing the use of (fake) simd * Clearly separate the bernstein/original version from the IETF standard version in term of counters size and nonce handling * Separate XChaCha from the 'normal' ChaCha context
also switch initialization to be less mutable
* performance bump by ~ 3x not using the fake simd instructions * separate salsa and xsalsa * add some docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.