Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer else over inverse #175

Merged
merged 2 commits into from Apr 20, 2021
Merged

Prefer else over inverse #175

merged 2 commits into from Apr 20, 2021

Conversation

wagenet
Copy link
Contributor

@wagenet wagenet commented Apr 20, 2021

Requires Yields to use else, but still allows for {{yields to="inverse"}}

@wagenet
Copy link
Contributor Author

wagenet commented Apr 20, 2021

See also glimmerjs/glimmer-vm#1296

@wagenet wagenet changed the title Prefer else over inverse. Prefer else over inverse Apr 20, 2021
@dfreeman dfreeman added the breaking A breaking change label Apr 20, 2021
@dfreeman
Copy link
Member

Thanks @wagenet (and apologies for immediately creating a merge conflict!)

Can you add a note to the README where we talk about Yields mentioning that inverse is an alias for else (and that you should use the latter in your types?)

@wagenet
Prefer else over inverse.
1926aff 
Requires `Yields` to use `else`, but still allows for
`{{yields to="inverse"}}`
@wagenet
Add note about Yields else to README
3d1f097
@dfreeman dfreeman merged commit 0a8dc2d into typed-ember:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfreeman dfreeman dfreeman approved these changes

Assignees
No one assigned
Labels
breaking A breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wagenet @dfreeman