Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix commitlint action config #1388

Merged
merged 1 commit into from
Nov 23, 2020
Merged

chore(ci): fix commitlint action config #1388

merged 1 commit into from
Nov 23, 2020

Conversation

chriskrycho
Copy link
Member

Since updating the checkout action, any rebased commit has been failing. This is because with @actions@v2, we need to set fetch-depth, because by default the checkout action only fetches the latest commit—a reasonable move for clone performance, but one that breaks the commitmlint action.

Aside: we may want to revisit the value of commitlint for this repo, as it's extra hassle for users and we're not actually making use of Semantic Release at this point. cc. @dfreeman @jamescdavis

@chriskrycho chriskrycho merged commit 059048d into master Nov 23, 2020
@chriskrycho chriskrycho deleted the fix-commitlint branch November 23, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant