feat: add storybook & designed component #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aylie-Chou
force-pushed
the
7-feature-add-storybook
branch
from
92cf3d5
to
6f3966f
Compare
taylrj
reviewed
Apr 22, 2022
taylrj
reviewed
Apr 22, 2022
taylrj
reviewed
Apr 22, 2022
taylrj
reviewed
Apr 22, 2022
Aylie-Chou
force-pushed
the
7-feature-add-storybook
branch
2 times, most recently
from
a9edf8f
to
ff9bbe4
Compare
taylrj
reviewed
Apr 29, 2022
Aylie-Chou
force-pushed
the
7-feature-add-storybook
branch
from
f9be3d5
to
628cebf
Compare
added 10 commits
May 3, 2022 13:47
- add component
- button
- pill button
- text
- headline
- paragraph
- icon
- divider
- notice
- icons are stored in gcs, may occur same-origin problem
- how to run storybook on local
- `yarn storybook`
- circleci: storybook job only run on master branch - storybook config: support deeper `stories` directory - pillButton: support withIcon props
|
As previous discussion, remove ci config for this patch. |
Aylie-Chou
force-pushed
the
7-feature-add-storybook
branch
from
d4e0700
to
ee0e7fe
Compare
taylrj
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add component
notice
how to run storybook on local
yarn storybook