Add fish completion support #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twpayne
reviewed
May 22, 2019
|
Thanks very much for this! |
twpayne
reviewed
Jun 5, 2019
|
It doesn't look like spf13/cobra#754 is going to be merged any time soon, but I'd still like to see this in chezmoi. If you agree, could you mark this PR as "Ready for review"? I'm happy to use @0robustus1's fork while waiting for @spf13 or any Cobra maintainer to merge the upstream PR. |
|
@twpayne sure let's do it 👍 |
|
Many thanks! The CI might be a bit too strict at times. |
|
Thanks for Fish completion! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of fish completion for chezmoi. Currently waiting on spf13/cobra#754 to get merged, then I'll clean up
go.mod.