Add (failing) test for stripping type attribute from ES module scri…

…pt tags
twome · Mar 30, 2019 · cb975b2 · cb975b2
1 parent 2f1091a
commit cb975b2
Show file tree

Hide file tree

Showing 4 changed files with 60 additions and 0 deletions.
diff --git a/packages/core/integration-tests/test/html.js b/packages/core/integration-tests/test/html.js
@@ -795,6 +795,49 @@ describe('html', function() {
     assert(html.includes('alert("Hello, World!")'));
   });
 
+  it('should strip `type` attribute from ES-module and "text/javascript" script tags', async function() {
+    let b = await bundle(
+      path.join(__dirname, '/integration/html-module-type-scripts/index.html'),
+      {production: true}
+    );
+
+    await assertBundleTree(b, {
+      name: 'index.html',
+      assets: ['index.html'],
+      childBundles: [
+        {
+          type: 'js',
+          assets: ['module.js'],
+          childBundles: [
+            {
+              type: 'map'
+            }
+          ]
+        },
+        {
+          type: 'js',
+          assets: ['text-javascript.js'],
+          childBundles: [
+            {
+              type: 'map'
+            }
+          ]
+        }
+      ]
+    });
+
+    let html = await fs.readFile(
+      path.join(__dirname, '/dist/index.html'),
+      'utf8'
+    );
+
+    console.debug(html);
+
+    assert(
+      !/type\s*=/.test(html) // No type="" attribute anywhere
+    );
+  });
+
   it('should handle inline css with @imports', async function() {
     let b = await bundle(
       path.join(__dirname, '/integration/html-inline-css-import/index.html'),

diff --git a/packages/core/integration-tests/test/integration/html-module-type-scripts/index.html b/packages/core/integration-tests/test/integration/html-module-type-scripts/index.html
@@ -0,0 +1,15 @@
+<!DOCTYPE html>
+<html lang="en">
+
+<head>
+  <title>Script tag type stripping - Parcel</title>
+
+  <script type="module" src="./module.js"></script>
+  <script type="text/javascript" src="./text-javascript.js"></script>
+</head>
+
+<body>
+  <h1>Hello world</h1>
+</body>
+
+</html>
diff --git a/packages/core/integration-tests/test/integration/html-module-type-scripts/module.js b/packages/core/integration-tests/test/integration/html-module-type-scripts/module.js
@@ -0,0 +1 @@
+var a = 1
diff --git a/packages/core/integration-tests/test/integration/html-module-type-scripts/text-javascript.js b/packages/core/integration-tests/test/integration/html-module-type-scripts/text-javascript.js
@@ -0,0 +1 @@
+var b = 2