Update tokio and use LocalSet for non-Send tasks #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to hold off on merging this until tokio-rs/tokio#1843 is merged and released. After that goes through we can hopefully remove the hacks from here. |
brayniac
reviewed
Nov 27, 2019
|
Currently blocked on tokio-rs/tokio#1885 |
|
tokio-rs/tokio#1892 should fix tokio-rs/tokio#1885 (thanks for the report @swlynch99!) |
swlynch99
force-pushed
the
update-tokio
branch
from
822db16
to
014da53
Compare
brayniac
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokio v0.2.1 adds back the ability to run non-send tasks. This PR removes the hack we had in place to do this and replaces it with LocalSet.
Unfortunately, the LocalSet API currently either panics or hangs when it is dropped with futures that are still live (as would happen when we intercept
SIGTERMand try to exit). In cases where these currently panic I've left them alone but I've added onemem::forgetcall to avoid an infinite loop.