Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to ktlint 0.47.0 #24

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Migrate to ktlint 0.47.0 #24

merged 3 commits into from
Aug 30, 2022

Commits on Aug 30, 2022

  1. Migrate to ktlint 0.47.0 

    There are a bunch of [breaking API changes](https://github.com/pinterest/ktlint/releases/tag/0.47.0) in the newest version of ktlint. Basically all rulesets need to be redefined. In 0.47.0 versions the previous ruleset versions coexist with the newers, so I added support for both in the mean time. In the future, the previous version of the rulesets will disappear. Also, undocumented by the migration guide, but all tests changed the way in which the assertThat classes are created, so I also updated all the tests to support the new version.

Spotless is not yet compatible with 0.47.0, so I disabled the checks until it is (will likely [land soon](diffplug/spotless#1303)).

I also updated all dependencies.
    @mrmans0n
    mrmans0n committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    437ce88 View commit details
    Browse the repository at this point in the history

  2. Use previous ktlint version and fix issues

    @mrmans0n
    mrmans0n committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    2eaaf93 View commit details
    Browse the repository at this point in the history

  3. Leave previous comment for simplicity

    @mrmans0n
    mrmans0n committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    af8b659 View commit details
    Browse the repository at this point in the history