Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit: a failing unit test to feature2d::BFMatcher #490

Merged
merged 3 commits into from
Apr 20, 2024

Conversation

sjbeskur
Copy link
Contributor

You don't really want to merge this yet but I could use some help figuring this out

@twistedfall
Copy link
Owner

Thanks! This is related to #489, am I right? I'm away from the computer at the moment for a while, but I'll check it as soon as possible

@sjbeskur
Copy link
Contributor Author

Yes that is correct this is related to issue #489. No rush and thanks for your attention.. Happy to help where I can be useful.

@sjbeskur
Copy link
Contributor Author

sjbeskur commented Sep 1, 2023

anyone have and further insights on this?

@twistedfall
Copy link
Owner

Sorry for taking so long to get back to you! In this case the problem is that you must use the train_match function instead of match_ like this:

	let mut matches = opencv::types::VectorOfDMatch::new();
	bf_matcher.train_match(&des_a, &des_b, &mut matches, &no_array()).unwrap();

@sjbeskur
Copy link
Contributor Author

Brilliant.. yep that did the trick. I've updated my pull request but maybe it's better as an example in case someone else has the same issue.

@twistedfall twistedfall merged commit a54ff12 into twistedfall:master Apr 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants