New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#10328] Remove coveralls as not used. Update codecov.io reporting version. #1715
Conversation
@@ -126,21 +126,12 @@ jobs: | |||
python -m coverage xml -o coverage.xml -i | |||
python -m coverage report --skip-covered | |||
|
|||
- uses: codecov/codecov-action@v1 | |||
- uses: codecov/codecov-action@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On most projects where I've seen codecov used, codecov posts a comment on PRs. I don't see such a comment on this PR though. Working as intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm... I see the coverage reports pushed at https://codecov.io/gh/twisted/twisted/commit/6eb7be783c15d4304b12ef25a0aa10dc2f9632b2/build
but yes. there is no commit status check report :(
Looks like this is due to the fact that Azure CI are no longer reported....and codecov.io was configured to wait for 15 other CI builds before reporting the results... to reduce confusion due to partial reports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you file a ticket about how Windows CI is broken and needs fixing then I think I'm happy to approve this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket created here https://twistedmatrix.com/trac/ticket/10331
It looks like there is a PR to move Windows runs on GHA but it has no ticket
Looks like Azure tests stopped working since #1681
The previous commit had the Azure test running, and in PR 1681 the Azure config was updated...
after_n_builds: 15 | ||
# We have at least 5 builds in GitHub Actions, | ||
# so try not to send the reports too soon with partial results. | ||
after_n_builds: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... the joy of manually counting small numbers of things because the computer cannot manage to do it ...
Scope and purpose
This tries to get CI green ... spring is coming :)
Update codecov actions script to v2 . V3 was failing.
Removed coveralls reporting as we were not using it.
Contributor Checklist:
tox -e lint
to format my patch to meet the Twisted Coding Standard#
character).review
to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.The first line is automatically generated by GitHub based on PR ID and branch name.
The other lines generated by GitHub should be replaced.