Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10328] Remove coveralls as not used. Update codecov.io reporting version. #1715

Merged
merged 4 commits into from Apr 11, 2022

Conversation

adiroiban
Copy link
Member

@adiroiban adiroiban commented Apr 11, 2022

Scope and purpose

This tries to get CI green ... spring is coming :)

Update codecov actions script to v2 . V3 was failing.
Removed coveralls reporting as we were not using it.

Contributor Checklist:

  • The associated ticket in Trac is here: https://twistedmatrix.com/trac/ticket/10328
  • [NA] I ran tox -e lint to format my patch to meet the Twisted Coding Standard
  • I have created a newsfragment in src/twisted/newsfragments/ (see: News files)
  • The title of the PR starts with the associated Trac ticket number (without the # character).
  • [NA] I have updated the automated tests and checked that all checks for the PR are green.
  • I have submitted the associated Trac ticket for review by adding the word review to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.
  • The merge commit will use the below format
    The first line is automatically generated by GitHub based on PR ID and branch name.
    The other lines generated by GitHub should be replaced.
Merge pull request #123 from twisted/4356-branch-name-with-trac-id

Author: adiroibam
Reviewer: 
Fixes: ticket:10238

Fix the CI build system to have green runs.
Use codecov action v2 to publish coverage.
Remove publishing to coveralls.

@adiroiban adiroiban requested a review from a team April 11, 2022 15:38
@@ -126,21 +126,12 @@ jobs:
python -m coverage xml -o coverage.xml -i
python -m coverage report --skip-covered

- uses: codecov/codecov-action@v1
- uses: codecov/codecov-action@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On most projects where I've seen codecov used, codecov posts a comment on PRs. I don't see such a comment on this PR though. Working as intended?

Copy link
Member Author

@adiroiban adiroiban Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm... I see the coverage reports pushed at https://codecov.io/gh/twisted/twisted/commit/6eb7be783c15d4304b12ef25a0aa10dc2f9632b2/build

but yes. there is no commit status check report :(

Looks like this is due to the fact that Azure CI are no longer reported....and codecov.io was configured to wait for 15 other CI builds before reporting the results... to reduce confusion due to partial reports

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you file a ticket about how Windows CI is broken and needs fixing then I think I'm happy to approve this PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ticket created here https://twistedmatrix.com/trac/ticket/10331


It looks like there is a PR to move Windows runs on GHA but it has no ticket

#1647


Looks like Azure tests stopped working since #1681

The previous commit had the Azure test running, and in PR 1681 the Azure config was updated...

image

after_n_builds: 15
# We have at least 5 builds in GitHub Actions,
# so try not to send the reports too soon with partial results.
after_n_builds: 5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... the joy of manually counting small numbers of things because the computer cannot manage to do it ...

@adiroiban adiroiban merged commit 6fccfbd into trunk Apr 11, 2022
@adiroiban adiroiban deleted the 10328-ci-coverage branch April 11, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants