Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9660] Fix a typo in GlibReactorBaseTests #1705

Closed
wants to merge 1 commit into from
Closed

[9660] Fix a typo in GlibReactorBaseTests #1705

wants to merge 1 commit into from

Conversation

yan12125
Copy link
Contributor

@yan12125 yan12125 commented Mar 18, 2022

Scope and purpose

Fix a typo in GlibReactorBaseTests

This is a regression of tests introduced in #1679. Apparently glib-related tests are not run on CI?

Contributor Checklist:

  • The associated ticket in Trac is here: https://twistedmatrix.com/trac/ticket/9660
  • I ran tox -e lint to format my patch to meet the Twisted Coding Standard
  • I have created a newsfragment in src/twisted/newsfragments/ (see: News files)
  • The title of the PR starts with the associated Trac ticket number (without the # character).
  • I have updated the automated tests and checked that all checks for the PR are green.
  • I have submitted the associated Trac ticket for review by adding the word review to the keywords field in Trac, and putting a link to this PR in the comment; it shows up in https://twisted.reviews/ now.
  • The merge commit will use the below format
    The first line is automatically generated by GitHub based on PR ID and branch name.
    The other lines generated by GitHub should be replaced.
Merge pull request #1705 from yan12125/9660-fix-GlibReactorBaseTests

Author: yan12125
Reviewer: <github_username>, <github_username_if_more_reviewers>
Fixes: ticket:9660

Fix a typo in GlibReactorBaseTests

@yan12125
Copy link
Contributor Author

Hmm, reusing the trac ticket number for a follow-up fix turns out not a good idea. Will create a new trac ticket along with a new PR.

@yan12125 yan12125 closed this Mar 19, 2022
@yan12125 yan12125 deleted the 9660-fix-GlibReactorBaseTests branch March 19, 2022 07:13
adiroiban added a commit that referenced this pull request Apr 2, 2022
Merge pull request #1705 from yan12125/10317-fix-GlibReactorBaseTests

Author: yan12125
Reviewer: exarkun
Fixes: ticket:10317

Fix a typo in GlibReactorBaseTests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant