Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12169 defer: Expand inline callbacks tests #12170

Merged
merged 7 commits into from
May 19, 2024

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    093f7a3 View commit details
    Browse the repository at this point in the history
  2. defer: Move basic inlineCallbacks tests to test_inlinecb

    deferredGenerator and inlineCallbacks tests just happen to be similar
    enough that some of them can be shared. However, this sharing is
    ephemeral because there's no underlying reason why both sets of tests
    should change both at the same time. Changes to how inlineCallbacks
    works will affect only that part of the test suite and changes to how
    deferredGenerator will affect only its part of the test suite as well.
    
    Duplicating the tests makes them easier to discover and understand.
    Additionally, this will need to be done at some point anyway because
    deferredGenerator has been deprecated.
    p12tic committed May 16, 2024
    Configuration menu
    Copy the full SHA
    1854484 View commit details
    Browse the repository at this point in the history
  3. defer: Move test-related helpers to within tests themselves

    This makes it much clearer which functions belong to which test without
    additional documentation.
    p12tic committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e56140a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b7beba9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    51f44e4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4d22b36 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Configuration menu
    Copy the full SHA
    b5e8b45 View commit details
    Browse the repository at this point in the history