Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6960 cfrunloopsourceinvalidate #12081

Closed
wants to merge 3 commits into from
Closed

Conversation

glyph
Copy link
Member

@glyph glyph commented Jan 12, 2024

Scope and purpose

Fixes #6960

Not sure if this is going to help that much, but if it's this simple it's worth trying.

@glyph
Copy link
Member Author

glyph commented Jan 12, 2024

Hmm, given that we got the same issue on the first build here, seems that we have not fixed it

@glyph
Copy link
Member Author

glyph commented Jan 12, 2024

(I wonder if this is still worth doing on its own merits?)

@adiroiban
Copy link
Member

adiroiban commented Jan 12, 2024

Thanks!

As long as we keep only the #6960 newsfragment in this PR, I think that we can still make the change.

@glyph
Copy link
Member Author

glyph commented Apr 4, 2024

As long as we keep only the #6969 newsfragment in this PR, I think that we can still make the change.

Do you mean #6960 ?

@adiroiban
Copy link
Member

Do you mean #6960 ?

Yes. Sorry. It was about #6960

@glyph
Copy link
Member Author

glyph commented May 3, 2024

I am not totally sure that this is correct and we have found another cause for #11771 so I am going to close this.

@glyph glyph closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CFRunLoopRemoveSourceInvalidate instead of CFRunLoopRemoveSource in CFReactor
2 participants