Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11793 deprecated legacy ciphers for conch #11794

Open
wants to merge 22 commits into
base: trunk
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/conch/man/conch.1
Expand Up @@ -108,7 +108,7 @@ Enable compression.
.It Fl c Ar cipher_spec
Selects encryption algorithms to be used for this connection, as a comma-separated list of ciphers in order of preference. The list that
.Nm
supports is (in order of default preference): aes256-ctr, aes256-cbc, aes192-ctr, aes192-cbc, aes128-ctr, aes128-cbc, cast128-ctr, cast128-cbc, blowfish-ctr, blowfish, idea-ctr, idea-cbc, 3des-ctr, 3des-cbc.
supports is (in order of default preference): aes256-ctr, aes256-cbc, aes192-ctr, aes192-cbc, aes128-ctr, aes128-cbc, 3des-ctr, 3des-cbc.
.It Fl e Ar ch | ^ch | none
Sets the escape character for sessions with a PTY (default:
.Ql ~ ) .
Expand Down
8 changes: 0 additions & 8 deletions src/twisted/conch/ssh/transport.py
Expand Up @@ -94,17 +94,13 @@ class SSHCiphers:

cipherMap = {
b"3des-cbc": (algorithms.TripleDES, 24, modes.CBC),
b"blowfish-cbc": (algorithms.Blowfish, 16, modes.CBC),
llouislu marked this conversation as resolved.
Show resolved Hide resolved
b"aes256-cbc": (algorithms.AES, 32, modes.CBC),
b"aes192-cbc": (algorithms.AES, 24, modes.CBC),
b"aes128-cbc": (algorithms.AES, 16, modes.CBC),
b"cast128-cbc": (algorithms.CAST5, 16, modes.CBC),
b"aes128-ctr": (algorithms.AES, 16, modes.CTR),
b"aes192-ctr": (algorithms.AES, 24, modes.CTR),
b"aes256-ctr": (algorithms.AES, 32, modes.CTR),
b"3des-ctr": (algorithms.TripleDES, 24, modes.CTR),
b"blowfish-ctr": (algorithms.Blowfish, 16, modes.CTR),
b"cast128-ctr": (algorithms.CAST5, 16, modes.CTR),
b"none": (None, 0, modes.CBC),
}
macMap = {
Expand Down Expand Up @@ -284,10 +280,6 @@ def _getSupportedCiphers():
b"aes192-cbc",
b"aes128-ctr",
b"aes128-cbc",
b"cast128-ctr",
llouislu marked this conversation as resolved.
Show resolved Hide resolved
b"cast128-cbc",
b"blowfish-ctr",
b"blowfish-cbc",
b"3des-ctr",
b"3des-cbc",
]
Expand Down
1 change: 1 addition & 0 deletions src/twisted/newsfragments/11793.removal
@@ -0,0 +1 @@
Twisted Conch has removed and no longer supports legacy ciphers (CAST5, SEED, IDEA, Blowfish) as the upstream library "cryptography" has deprecated them since version 37.