Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uts46 and transitional to idna.encode/decode to support legacy emoji and idna domains #11760

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

john-parton
Copy link

@john-parton john-parton commented Nov 17, 2022

Scope and purpose

Fixes #10078

Should fix scrapy/scrapy#4330 (comment) once Scrapy uses version of Twisted with patch

Still need tests.

You can see some discussion on exactly what this does here: kjd/idna#18
And also the IDNA docs: https://github.com/kjd/idna#compatibility-mapping-uts-46

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

@glyph
Copy link
Member

glyph commented Nov 17, 2022

I know you're not ready for review here yet, but I'm looking forward to this: thank you for the contribution!

@john-parton
Copy link
Author

I know you're not ready for review here yet, but I'm looking forward to this: thank you for the contribution!

I don't think I'm going to be able to add a test, docs, or anything supplementary, unfortunately.

@glyph glyph added the abandoned The original author will not be completing the work, but maybe someone else can pick it up. label Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned The original author will not be completing the work, but maybe someone else can pick it up.
Projects
None yet
2 participants