Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11713 Remove historical docs from RTD #11714

Merged
merged 1 commit into from Oct 16, 2022

Conversation

JudgeGregg
Copy link
Contributor

Scope and purpose

Fixes #11713
Remove historical docs from RTD since it can confuse Twisted users.

Add any comments about trade-offs (if any) made in this PR and the reasoning behind them:
We lose "history" but it's available in the repo and internet archives:

#11684 (comment)

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

@JudgeGregg
Copy link
Contributor Author

please review

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.

I have created this repo https://github.com/twisted/historic

For which the files are available at https://twisted.org/historic/

If you have time, I have added you to that repo.
Can you copy these removed files there?

In this way, there is still a way to check them... if needed
and we can add a redirection rule later for twisted.org

@adiroiban adiroiban merged commit 4b62da0 into twisted:trunk Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove historical docs from RTD
3 participants