Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11696 maybeDeferred annotations #11697

Merged
merged 4 commits into from Oct 1, 2022

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Sep 30, 2022

Scope and purpose

Fixes #11696

It is tempting to elaborate on the return type of `f` in the annotation.
However, since ultimately it also includes `_T`, the cases all overlap and
this is futile.
@exarkun exarkun marked this pull request as ready for review September 30, 2022 15:24
@chevah-robot chevah-robot requested a review from a team September 30, 2022 15:24
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good. Should be merged.

@exarkun exarkun merged commit 968bfdd into twisted:trunk Oct 1, 2022
@exarkun exarkun deleted the 11696-maybeDeferred-annotations branch October 1, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give execute and maybeDeferred correct type annotations
3 participants