#11692 cleanup trial runner #11693

exarkun · 2022-09-27T01:18:23Z

Scope and purpose

adiroiban

Many thanks for the cleanup

Other than the test case name implementation, this looks good.

I think this can be merged.

I don't see anything horrible here that should block a merge (other than the name part :)

src/twisted/scripts/trial.py

src/twisted/trial/runner.py

src/twisted/trial/util.py

src/twisted/trial/_dist/disttrial.py

exarkun added 6 commits September 26, 2022 16:06

A lot of cleanups centered around TrialRunner

a824cd5

Annotate a few other pieces where script and runner interact

5792b6b

some further improvements, mostly type annotations

36694e5

Remove some unused attributes

3d70ae8

news fragment

f22b885

python 3.7 compat

7da5aa0

exarkun marked this pull request as ready for review September 27, 2022 02:04

chevah-robot added the needs-review label Sep 27, 2022

chevah-robot requested a review from a team September 27, 2022 02:04

adiroiban approved these changes Sep 27, 2022

View reviewed changes

chevah-robot added needs-merge and removed needs-review labels Sep 27, 2022

exarkun added 4 commits September 27, 2022 17:08

_result is no longer used

fedc480

docs for runner instance vars

730d535

expand the link

5ab99ae

Favor human readers over mypy

e5bb8f9

exarkun merged commit 0929f3f into twisted:trunk Sep 27, 2022

exarkun deleted the 11692-cleanup-trial-runner branch September 27, 2022 22:31