Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11686 Fix test_openFileDescriptors in some environments. #11687

Merged
merged 1 commit into from Sep 24, 2022
Merged

#11686 Fix test_openFileDescriptors in some environments. #11687

merged 1 commit into from Sep 24, 2022

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Sep 24, 2022

Scope and purpose

Fixes #11686

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

@tjni tjni changed the title [#11686] Fix test_openFileDescriptors in some environments. #11686 Fix test_openFileDescriptors in some environments. Sep 24, 2022
@tjni
Copy link
Contributor Author

tjni commented Sep 24, 2022

please review

Copy link
Contributor

@twm twm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tjni, this looks like a solid improvement. I guess setting PYTHONPATH is sometimes necessary because Trial changes the working directory. Thank you for the fix!

@twm twm merged commit 47f4763 into twisted:trunk Sep 24, 2022
@tjni tjni deleted the 11686-fix-tests branch September 24, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

twisted.internet.test.test_process.*.test_openFileDescriptors fails in nixpkgs
3 participants