Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11647 fix template typo #11648

Merged
merged 3 commits into from Sep 8, 2022
Merged

#11647 fix template typo #11648

merged 3 commits into from Sep 8, 2022

Conversation

glyph
Copy link
Member

@glyph glyph commented Sep 7, 2022

Scope and purpose

Fixes #11647

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string needs-review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

@glyph
Copy link
Member Author

glyph commented Sep 7, 2022

needs-review

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Maybe while at it

-* Once all checks are green, request a review by leaving a comment that contains exactly the string `needs-review`.
+* Once all checks are green, request a review by leaving a comment that contains exactly the string `please review`.

Not sure what is the preferred trigger workd

The current bot works with:

  • needs-review
  • please review
  • review please

But I think it fails if there is full stop at the end.

@glyph glyph enabled auto-merge September 7, 2022 22:31
@adiroiban
Copy link
Member

There was a flaky test :(

re-run trigerred

twisted.trial.unittest.FailTest: 1 != 0 : Warnings found at the end of the test:
[{'message': 'unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=False>', 'category': <class 'ResourceWarning'>, 'filename': '/opt/hostedtoolcache/Python/3.9.13/x64/lib/python3.9/asyncio/base_events.py', 'lineno': 686}]

twisted.internet.test.test_posixbase.WakerTests.test_noWakerConstructionWarnings

@glyph glyph merged commit b96acd7 into trunk Sep 8, 2022
@glyph glyph deleted the 11647-typo branch September 8, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

it's spelled "exhaustive"
3 participants