Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11645 all rtd formats #11646

Merged
merged 3 commits into from Sep 7, 2022
Merged

#11645 all rtd formats #11646

merged 3 commits into from Sep 7, 2022

Conversation

glyph
Copy link
Member

@glyph glyph commented Sep 7, 2022

Scope and purpose

Fixes #11645

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exaustive list (as a reminder):

  • The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
  • A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
  • The automated tests were updated.
  • Once all checks are green, request a review by leaving a comment that contains exactly the string needs-review.
    Our bot will trigger the review process, by applying the pending review label
    and requesting a review from the Twisted dev team.

formats:
- pdf
- epub
formats: all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment that we have "all" as it should include htmlzip and we want htmlzip for offline docs readers.

Just a help with someone touching this in the future.
Most probably that person will not check the whole history of this line..
and might think that "all" is excessive and html and PDF should be enough.

@glyph
Copy link
Member Author

glyph commented Sep 7, 2022

needs-review

Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Looks good.
I hope RTD build will pass.

@glyph glyph enabled auto-merge September 7, 2022 22:44
@glyph glyph merged commit 016f2bc into trunk Sep 7, 2022
@glyph glyph deleted the 11645-all-rtd-formats branch September 7, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable "all" readthedocs formats
3 participants