#11640 run twistd tests #11641
Merged
#11640 run twistd tests #11641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiroiban
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Looks good.
I think that we can add a codecov.io / coverage report for any test code
For example the files from src/twisted/test should always have 100% coverage.
if the coverage is below 100% it means that some test code is never executed...and this is bad thing.
|
@exarkun I have disabled auto-merged... as I thought that this is why I can't update this branch. But I think that the PR was created for a branch to which Twisted devs don't have write access. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #11640
Just makes the obvious spelling fix so if the correct dependencies are available the tests can run.