Debug windows conch failures #11624
Closed
Debug windows conch failures #11624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are handy for writing hamcrest-based tests for a lot of trial code.
The previous implementation used unnecessary fakes and encoded unnecessary implementation details as well as unnecessarily duplicating in-memory ITransport implementation available in other testing libraries in Twisted. This is an almost-no-behavior-change commit that just makes the tests simpler and exercises the code under test in a more realistic way.
make sure stopTest is called only once and with the right argument
This also removes the need for isTuple
They disagree with the inherited type which makes TestResult a very poorly behaved subclass. But, so it is.
|
Might be about time to move Windows test on GitHub action and enable https://github.com/mxschmitt/action-tmate i think is the best experience for troubleshooting tests on Windows . If a test fails on Win or macOs, after the test run fails I connect via SSH and re-run and do debugging directly on the VM We have this draft #1647 so maybe continue working on it. |
exarkun
force-pushed
the
debug-windows-conch-failures
branch
from
db6c722
to
416afd0
Compare
|
This didn't really help and I'm done with it now anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for debugging Windows CI failures for #11616