Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.13: test_findFailureInGenerator and _test_urlParameters_1 fail #12099

Open
befeleme opened this issue Jan 30, 2024 · 1 comment
Open

Python 3.13: test_findFailureInGenerator and _test_urlParameters_1 fail #12099

befeleme opened this issue Jan 30, 2024 · 1 comment
Labels
bug

Comments

@befeleme
Copy link

Describe the incorrect behavior you saw
When building twisted for Fedora Linux 40 with Python 3.13.0a3, there are test failures occurring.
The reported failures are what's left after testing various already prepared fixes from this project. I believe the ones reported below were not yet spotted.

[FAIL]
Traceback (most recent call last):
  File "/builddir/build/BUILD/twisted-twisted-23.10.0/src/twisted/test/test_failure.py", line 967, in test_findFailureInGenerator
    self.assertEqual(foundFailures, [f])
  File "/builddir/build/BUILD/twisted-twisted-23.10.0/src/twisted/trial/_synctest.py", line 444, in assertEqual
    super().assertEqual(first, second, msg)
  File "/usr/lib64/python3.13/unittest/case.py", line 887, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib64/python3.13/unittest/case.py", line 1093, in assertListEqual
    self.assertSequenceEqual(list1, list2, msg, seq_type=list)
  File "/usr/lib64/python3.13/unittest/case.py", line 1075, in assertSequenceEqual
    self.fail(msg)
twisted.trial.unittest.FailTest: Lists differ: [None] != [<twisted.python.failure.Failure builtins.ZeroDivisionError: division by zero>]

First differing element 0:
None
<twisted.python.failure.Failure builtins.ZeroDivisionError: division by zero>

- [None]
+ [<twisted.python.failure.Failure builtins.ZeroDivisionError: division by zero>]

twisted.test.test_failure.ExtendedGeneratorTests.test_findFailureInGenerator
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "/builddir/build/BUILD/twisted-twisted-23.10.0/src/twisted/web/test/test_cgi.py", line 389, in _test_urlParameters_1
    self.assertEqual(res, expected)
  File "/builddir/build/BUILD/twisted-twisted-23.10.0/src/twisted/trial/_synctest.py", line 444, in assertEqual
    super().assertEqual(first, second, msg)
  File "/usr/lib64/python3.13/unittest/case.py", line 887, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib64/python3.13/unittest/case.py", line 880, in _baseAssertEqual
    raise self.failureException(msg)
twisted.trial.unittest.FailTest: b'\n<html>\n  <head><title>500 - CGI Script[125 chars]l>\n' != b'1234\n'

twisted.web.test.test_cgi.CGIScriptTests.test_urlParameters

Testing environment

  • Fedora Linux 40
  • Twisted version 23.10.0
@befeleme befeleme added the bug label Jan 30, 2024
@adiroiban
Copy link
Member

Thanks for the report.

Do you have time to review a Python 3.13 for a PR

This PR introduces the initial test run on Python 3.13 for Twisted

#12059

With that merged, it should be easier to do Python 3.13 developemt. we can run the changes on 3.13 and make sure they work.

Thanks!

@eevelweezel eevelweezel mentioned this issue Mar 9, 2024
Open
@eevelweezel eevelweezel mentioned this issue Mar 21, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adiroiban @befeleme