Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes cfreactor fails twisted.internet.test.test_fdset.ReactorFDSetTestsBuilder_CFReactorTests.test_addReader with 120 second TimeoutError #11771

Closed
exarkun opened this issue Nov 22, 2022 · 3 comments · Fixed by #12160 · May be fixed by #12150
Closed

Sometimes cfreactor fails twisted.internet.test.test_fdset.ReactorFDSetTestsBuilder_CFReactorTests.test_addReader with 120 second TimeoutError #11771

exarkun opened this issue Nov 22, 2022 · 3 comments · Fixed by #12160 · May be fixed by #12150
Labels
bug

Comments

@exarkun
Copy link
Member

exarkun commented Nov 22, 2022 

===============================================================================
Error: 
Traceback (most recent call last):
  File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.11/site-packages/twisted/internet/test/test_fdset.py", line 91, in test_addReader
    self.runReactor(reactor)
  File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.11/site-packages/twisted/internet/test/reactormixins.py", line 337, in runReactor
    raise TestTimeoutError(f"reactor still running after {timeout} seconds")
twisted.internet.test.reactormixins.TestTimeoutError: reactor still running after 120.0 seconds

twisted.internet.test.test_fdset.ReactorFDSetTestsBuilder_CFReactorTests.test_addReader
===============================================================================
Error: 
Traceback (most recent call last):
  File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.11/site-packages/twisted/internet/base.py", line 1049, in runUntilCurrent
    call.func(*call.args, **call.kw)
  File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.11/site-packages/twisted/internet/test/reactormixins.py", line 332, in stop
    reactor.stop()
  File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.11/site-packages/twisted/internet/cfreactor.py", line 538, in stop
    PosixReactorBase.stop(self)
  File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.11/site-packages/twisted/internet/base.py", line 757, in stop
    raise error.ReactorNotRunning("Can't stop reactor that isn't running.")
twisted.internet.error.ReactorNotRunning: Can't stop reactor that isn't running.

twisted.internet.test.test_fdset.ReactorFDSetTestsBuilder_CFReactorTests.test_addReader
-------------------------------------------------------------------------------
@exarkun exarkun added the bug label Nov 22, 2022
@exarkun exarkun mentioned this issue Nov 22, 2022
Merged
@exarkun
Copy link
Member Author

exarkun commented Nov 22, 2022

Also twisted.internet.test.test_tcp.AbortConnectionTests_CFReactorTests.test_fullWriteBufferAfterByteExchange

@glyph
Copy link
Member

glyph commented Jan 12, 2024

I believe #12029 is a duplicate of this?

@glyph glyph mentioned this issue Jan 12, 2024
Closed
@glyph
Copy link
Member

glyph commented Jan 14, 2024

Sometimes it's twisted.internet.test.test_process.ProcessTestsBuilder_CFReactorTests.test_pauseAndResumeProducing too. Not sure if this is the same bug.

===============================================================================
Error: 
Traceback (most recent call last):
  File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.8/site-packages/twisted/internet/test/test_process.py", line 888, in test_pauseAndResumeProducing
    self.runReactor(reactor)
  File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.8/site-packages/twisted/internet/test/reactormixins.py", line 351, in runReactor
    raise TestTimeoutError(f"reactor still running after {timeout} seconds")
twisted.internet.test.reactormixins.TestTimeoutError: reactor still running after 120.0 seconds

twisted.internet.test.test_process.ProcessTestsBuilder_CFReactorTests.test_pauseAndResumeProducing
===============================================================================
Error: 
Traceback (most recent call last):
  File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.8/site-packages/twisted/internet/base.py", line 1090, in runUntilCurrent
    call.func(*call.args, **call.kw)
  File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.8/site-packages/twisted/internet/test/reactormixins.py", line 346, in stop
    reactor.stop()
  File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.8/site-packages/twisted/internet/cfreactor.py", line 536, in stop
    PosixReactorBase.stop(self)
  File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.8/site-packages/twisted/internet/base.py", line 794, in stop
    raise error.ReactorNotRunning("Can't stop reactor that isn't running.")
twisted.internet.error.ReactorNotRunning: Can't stop reactor that isn't running.

twisted.internet.test.test_process.ProcessTestsBuilder_CFReactorTests.test_pauseAndResumeProducing
-------------------------------------------------------------------------------
Ran 10791 tests in 176.943s

https://github.com/twisted/twisted/actions/runs/7521167302/job/20471684152?pr=12083

@glyph glyph changed the title Sometimes cfreactor fails some test_addReader Sometimes cfreactor fails twisted.internet.test.test_fdset.ReactorFDSetTestsBuilder_CFReactorTests.test_addReader with 120 second TimeoutError Jan 14, 2024
@glyph glyph mentioned this issue Jan 14, 2024
Closed
@adiroiban adiroiban mentioned this issue Mar 18, 2024
Closed
This was referenced May 1, 2024
Draft
Merged
adiroiban added a commit that referenced this issue May 3, 2024
@adiroiban
#11771 make cfreactor less flaky (#12160)
3eba981
@glyph glyph mentioned this issue May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@exarkun @glyph