Type annotations, checked with MyPy #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that this behavior made more sense in the Python 2 days, but now it's just a hazard.
twm
force-pushed
the
typing
branch
2 times, most recently
from
2836f28
to
0a49042
Compare
This is necessary on Python 3.7 because type is not subscriptable.
glyph
approved these changes
May 3, 2023
|
Also if you're feeling reciprocal I could really use some reviews on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are tons of unions of concrete types in the APIs because treq does tons of
isinstance()checks internally. It's pretty gross.This targets Python 3.8 for MyPy to match what Twisted uses, so the 3.7 build is busted.
Fixes #302.