Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 2.7 and 3.5 #320

Merged
merged 19 commits into from Jan 24, 2021
Merged

Drop support for Python 2.7 and 3.5 #320

merged 19 commits into from Jan 24, 2021

Conversation

twm
Copy link
Contributor

@twm twm commented Jan 16, 2021 •
edited

  • Update package metadata to require Python 3.6 or later.
  • Drop compatibility dependencies six and mock.

Closes #318.

@twm twm marked this pull request as ready for review January 16, 2021 22:00
@twm twm requested a review from a team January 16, 2021 22:02
Julian
Julian reviewed Jan 16, 2021
View reviewed changes
setup.py Outdated Show resolved Hide resolved
Julian
Julian reviewed Jan 16, 2021
View reviewed changes
src/treq/client.py Outdated Show resolved Hide resolved
Julian
Julian reviewed Jan 16, 2021
View reviewed changes
src/treq/multipart.py Outdated Show resolved Hide resolved
adiroiban
adiroiban approved these changes Jan 17, 2021
View reviewed changes
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

Julian already did a great review.

I think that this PR has only minor comments and can be merged without another round of reviews.

Well done!

@twm
Copy link
Contributor Author

twm commented Jan 24, 2021

Thank you for the reviews, @Julian and @adiroiban! I'll merge this as it greens up.

@twm twm merged commit e3a12f8 into twisted:master Jan 24, 2021
@twm twm deleted the bye-bye-py27,py35-318 branch January 24, 2021 20:56
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Mar 3, 2022
upgpkg: python-treq 22.2.0-1; adopt, update, remove unneeded dependen…
7dd8a7c 
…cy [1] and try to make it reproducible

[1] python-mock is not needed since upstream version 21.5.0 twisted/treq#320

git-svn-id: file:///srv/repos/svn-community/svn@1140684 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Mar 3, 2022
upgpkg: python-treq 22.2.0-1; adopt, update, remove unneeded dependen…
9d5e693 
…cy [1] and try to make it reproducible

[1] python-mock is not needed since upstream version 21.5.0 twisted/treq#320


git-svn-id: file:///srv/repos/svn-community/svn@1140684 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julian Julian Julian left review comments

@graingert graingert graingert left review comments

@adiroiban adiroiban adiroiban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for Python 2.7 and 3.5
4 participants
@twm @adiroiban @Julian @graingert