Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for short/long file tuples #299

Merged
merged 10 commits into from Dec 28, 2020
Merged

Improve error message for short/long file tuples #299

merged 10 commits into from Dec 28, 2020

Commits on Sep 30, 2020

  1. Improve error message for short/long file tuples 

    If passed a tuple with a length other than 2 or 3 IBodyProducer would
end up trying to adapt None, producing this confusing message:

    Traceback (most recent call last):
      File ".../treq/test/test_client.py", line 513, in test_request_files_bad_tuples
        self.client.request(
      File ".../treq/client.py", line 190, in request
        bodyProducer, contentType = self._request_body(
      File ".../treq/client.py", line 297, in _request_body
        files = list(_convert_files(files))
      File ".../treq/client.py", line 388, in _convert_files
        yield (param, (file_name, content_type, IBodyProducer(fobj)))
    builtins.TypeError: ('Could not adapt', None, <InterfaceClass twisted.web.iweb.IBodyProducer>)

This changeset produces a TypeError that mentions tuple length.
    @twm
    twm committed Sep 30, 2020
    Copy the full SHA
    7b7cfef View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @twm
    twm committed Sep 30, 2020
    Copy the full SHA
    5127428 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2020

  1. Merge branch 'master' into ibodyproducer-files-tuples-length

    @twm
    twm committed Oct 10, 2020
    Copy the full SHA
    67672e0 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. Merge branch 'master' into ibodyproducer-files-tuples-length

    @twm
    twm committed Nov 27, 2020
    Copy the full SHA
    1c5677e View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2020

  1. Merge branch 'master' into ibodyproducer-files-tuples-length

    @twm
    twm committed Dec 27, 2020
    Copy the full SHA
    2978487 View commit details
    Browse the repository at this point in the history

  2. Wrap long line

    @twm
    twm committed Dec 27, 2020
    Copy the full SHA
    a613b0c View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2020

  1. Merge branch 'master' into ibodyproducer-files-tuples-length

    @twm
    twm committed Dec 28, 2020
    Copy the full SHA
    a905cc4 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Adi Roiban <adiroiban@gmail.com>
    @twm @adiroiban
    twm and adiroiban committed Dec 28, 2020
    Copy the full SHA
    1386169 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into ibodyproducer-files-tuples-length

    @twm
    twm committed Dec 28, 2020
    Copy the full SHA
    9f3026c View commit details
    Browse the repository at this point in the history

  4. Wrap long line

    @twm
    twm committed Dec 28, 2020
    Copy the full SHA
    ebe28ff View commit details
    Browse the repository at this point in the history