Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit-extension #594

Merged
merged 4 commits into from
May 6, 2024
Merged

Edit-extension #594

merged 4 commits into from
May 6, 2024

Conversation

SmileyChris
Copy link
Contributor

@SmileyChris SmileyChris commented May 6, 2024

Description

The temporary file towncrier create creates now uses the correct .rst or .md extension, which may help your editor with with syntax highlighting.

Fixes #527

Checklist

  • Make sure changes are covered by existing or new tests.
  • For at least one Python version, make sure local test run is green.
  • Create a file in src/towncrier/newsfragments/. Describe your
    change and include important information. Your change will be included in the public release notes.
  • Make sure all GitHub Actions checks are green (they are automatically checking all of the above).

@SmileyChris SmileyChris requested a review from a team as a code owner May 6, 2024 20:48
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@adiroiban adiroiban merged commit 9fe485d into twisted:trunk May 6, 2024
15 checks passed
@adiroiban
Copy link
Member

Many thanks Chris for the improvements!

@SmileyChris SmileyChris deleted the edit-extension branch May 14, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using towncrier create --edit, use .md or .rst
2 participants