Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --keep option to allow to generate newsfile, but keep newsfragmen… #453

Merged
merged 9 commits into from Dec 19, 2022
Merged

Add --keep option to allow to generate newsfile, but keep newsfragmen… #453

merged 9 commits into from Dec 19, 2022

Commits on Nov 24, 2022

  1. Add --keep option to allow to generate newsfile, but keep newsfragmen… 

    …ts - closes twisted#129
    @fizyk
    fizyk committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    19f1fe0 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Adi Roiban <adiroiban@gmail.com>
    @fizyk @adiroiban
    fizyk and adiroiban committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    0ee66f1 View commit details
    Browse the repository at this point in the history

  2. Additional post-PR enhancements

    @fizyk
    fizyk committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    3b44cec View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Update build --keep comment to be more relevant 

    Co-authored-by: Adi Roiban <adiroiban@gmail.com>
    @fizyk @adiroiban
    fizyk and adiroiban committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6dc3e63 View commit details
    Browse the repository at this point in the history

  2. More compact remove_files and use with_isolated_runner for new tests

    @fizyk
    fizyk committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    bf049f7 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. Refactored _git.remove_files 

        Code making decision to remove prompt or keep news fragments
    is being kept in new intermediate function _remover.remove_news_fragment_files
    @fizyk
    fizyk committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    0445078 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Update src/towncrier/newsfragments/129.feature 

    Co-authored-by: Hynek Schlawack <hs@ox.cx>
    @fizyk @hynek
    fizyk and hynek committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    1908de0 View commit details
    Browse the repository at this point in the history

  2. Make a decision and return it instead of calling _git.remove underneath

    @fizyk
    fizyk committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    ab17b50 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. Move should_remove_fragment_files into build module

    @fizyk
    fizyk committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    c5dadf0 View commit details
    Browse the repository at this point in the history