Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report git's output when git fails #125

Merged
merged 4 commits into from
Sep 7, 2018

Conversation

exarkun
Copy link
Member

@exarkun exarkun commented Aug 8, 2018

Fixes #124

@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #125 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   93.43%   93.29%   -0.15%     
==========================================
  Files          15       15              
  Lines         640      626      -14     
  Branches       65       65              
==========================================
- Hits          598      584      -14     
  Misses         26       26              
  Partials       16       16
Impacted Files Coverage Δ
src/towncrier/check.py 94% <100%> (+0.66%) ⬆️
src/towncrier/test/test_check.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7889f54...2b81b5d. Read the comment docs.

@hawkowl
Copy link
Member

hawkowl commented Sep 6, 2018

@exarkun could you merge this forward? I'm assuming that the create_project change would work in the other tests?

@exarkun
Copy link
Member Author

exarkun commented Sep 6, 2018

@hawkowl Done

@hawkowl hawkowl merged commit 47754a6 into twisted:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants