Temporary fix for UTF-8 bug in addressable #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary fix for #62. Related to sporkmonger/addressable#224
|
I think this looks good |
| raise | ||
| end | ||
|
|
||
| private :new, :internal_parse, :to_addressable_uri, :addressable_display_uri |
There was a problem hiding this comment.
what about splitting this line to multiple lines, so next time we get the nice diff :)
There was a problem hiding this comment.
Sure. What is the best way of doing that?
private :new,
:internal_parse,
:to_addressable_uri,
:addressable_display_uri
# or
private :new
private :internal_parse
private :to_addressable_uri
private :addressable_display_uriFor the second one we wouldn't have to add a , on the last line when adding a symbol, so I think that one looks best :).
There was a problem hiding this comment.
I like the second one (easier to remove/add line).
There was a problem hiding this comment.
Yeah, sure let's go with the second one :)
|
I'll create a new gem version after #78 is merged too. |
roback
added a commit
that referenced
this pull request
Feb 3, 2016
…tf-8 Temporary fix for UTF-8 bug in addressable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #62.
Related to sporkmonger/addressable#224
Used the code in #62 (comment) as inspiration, but I had to modify it so we didn't have to call
addressable.display_uritwice.