Skip to content

Commit

Permalink
Update Changelog with unreleased changes
Browse files Browse the repository at this point in the history
  • Loading branch information
jage committed Feb 5, 2019
1 parent ecfa92a commit 8216124
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
# Change Log

## [Unreleased](https://github.com/twingly/twingly-url/tree/HEAD)

[Full Changelog](https://github.com/twingly/twingly-url/compare/v5.1.1...HEAD)

**Fixed bugs:**

- Array\#uniq does not remove equal Twingly::URLs [\#123](https://github.com/twingly/twingly-url/issues/123)
- uninitialized constant Addressable::IDNA::PunycodeBigOutput \(NameError\) [\#119](https://github.com/twingly/twingly-url/issues/119)

**Merged pull requests:**

- Implement uniqueness \(hash equality\) [\#129](https://github.com/twingly/twingly-url/pull/129) ([jage](https://github.com/jage))
- Freeze string literals and mutable constants [\#128](https://github.com/twingly/twingly-url/pull/128) ([jage](https://github.com/jage))
- Support: Ruby 2.6, 2.5, 2.4, drop 2.2, 2.3 [\#127](https://github.com/twingly/twingly-url/pull/127) ([jage](https://github.com/jage))
- Remove Twingly::URL::Hasher.pingloggerdb\_hash [\#124](https://github.com/twingly/twingly-url/pull/124) ([walro](https://github.com/walro))

This comment has been minimized.

Copy link
@dentarg

dentarg Feb 5, 2019

Collaborator

Major version bump because of this? :-)

This comment has been minimized.

Copy link
@dentarg

dentarg Feb 5, 2019

Collaborator

Was briefly mentioned in: #124 :-)

This comment has been minimized.

Copy link
@walro

walro Feb 5, 2019

Contributor

Is it breaking if no one hears it being removed? Deep thoughts.

This comment has been minimized.

Copy link
@jage

jage Feb 5, 2019

Author Contributor

I was thinking major, we're already at v5, so why not v6? :)
An alternative could be to back it out and just add a warning ...

This comment has been minimized.

Copy link
@walro

walro Feb 5, 2019

Contributor

Seeing we drop Ruby 2.2 and 2.3 support I assume there's no harm in going major here.

This comment has been minimized.

Copy link
@dentarg

dentarg Feb 5, 2019

Collaborator

It doesn't look like we have promised to follow SemVer so I think we can just forget that I brought this up.

https://github.com/twingly/twingly-url/search?q=semver&unscoped_q=semver
https://github.com/twingly/twingly-url/search?q=semantic&unscoped_q=semantic

This comment has been minimized.

Copy link
@jage

jage Feb 5, 2019

Author Contributor

But I think we've followed SemVer before, so why break it now?

This comment has been minimized.

Copy link
@dentarg

dentarg Feb 5, 2019

Collaborator

Sure, we can bump major, no problemo.

This comment has been minimized.

Copy link
@jage

jage Feb 5, 2019

Author Contributor

Seeing we drop Ruby 2.2 and 2.3 support I assume there's no harm in going major here.

I thought bundler/rubygems took care of that, i.e. not possible to installed the next version on 2.2/2.3, so basically a patch version would do? But a major version will indicate but much have changed, which it will for someone on Ruby 2.2 (nothing works). :)

This comment has been minimized.

Copy link
@walro

walro Feb 5, 2019

Contributor

I have seen other gem maintainers going major due to that, I agree with both standpoints πŸ˜„.

This comment has been minimized.

Copy link
@jage

jage Feb 5, 2019

Author Contributor

Yeah, I've seen both. Checked Puma just now, minor bump. :)

https://github.com/puma/puma/blob/36964ec42982d7b3205760bc2bf9ccf3fec8af69/History.md#3120--2018-07-13
puma/puma#1506

In this case it doesn't matter since we're going to do a major bump nonetheless. :)

- Fix various warnings [\#122](https://github.com/twingly/twingly-url/pull/122) ([walro](https://github.com/walro))
- Load the pure-Ruby IDNA implementation from Addressable [\#120](https://github.com/twingly/twingly-url/pull/120) ([dentarg](https://github.com/dentarg))

## [v5.1.1](https://github.com/twingly/twingly-url/tree/v5.1.1) (2018-02-14)
[Full Changelog](https://github.com/twingly/twingly-url/compare/v5.1.0...v5.1.1)

Expand Down

0 comments on commit 8216124

Please sign in to comment.