Update marked due to CVE-2017-1000427 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marked is a dependency of jsdoc. Added marked as a dev dependency to be able to update it to latest version. This is just a temporary fix until jsdoc/jsdoc#1489 has been released. Idea from jsdoc/jsdoc#1489 (comment) Related to #22 https://nvd.nist.gov/vuln/detail/CVE-2017-1000427
|
Failures could potentially be because we run against latest node. Maybe we should only test against maintained LTS versions? See: https://github.com/nodejs/Release |
|
|
|
The tests fails on Node |
Closed
I'm not sure this works or if you have to specify an exact version for "allow_failures". Anyway, this is just a temporary fix until #24 has been solved. Also cleaned up the version we test against: * 5.x and 7.x removed as their EOL was at 2016-06-30 * 8.x is the current active LTS release (see https://github.com/nodejs/Release)
walro
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nvd.nist.gov/vuln/detail/CVE-2017-1000427
Marked is a dependency of jsdoc. Added marked as a dev dependency to be able to update it to latest version. This is just a temporary fix until jsdoc/jsdoc#1489 has been released.
Idea from jsdoc/jsdoc#1489 (comment)
Related to #22