Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make ruby-head test optional #579

Merged
merged 3 commits into from
Nov 23, 2021
Merged

chore: make ruby-head test optional #579

merged 3 commits into from
Nov 23, 2021

Conversation

eshanholtz
Copy link
Contributor

@eshanholtz eshanholtz commented Nov 23, 2021

Rubocop linting fails on ruby-head tests (aka ruby v3.1.0). Response from rubocop team is to upgrade from rubocop 0.82.0 to v1.22.3. We cannot do this until we drop support for ruby v2.4 in this helper. This PR allows test workflows to run and pass with success even if the single ruby-head test fails.

@eshanholtz eshanholtz merged commit b390fb3 into main Nov 23, 2021
@eshanholtz eshanholtz deleted the rubocop branch November 23, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants