Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Updated docstrings for timeout to be float instead of int #631

Merged
merged 2 commits into from
Dec 14, 2022
Merged

docs: Updated docstrings for timeout to be float instead of int #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb9ff05
Updated docs for timeout to be float instead of int
Dec 12, 2022
1f4b510
Resolves FLK-D204 error, despite me not touching that file
Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion twilio/base/domain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ class Domain(object):

Like, `api.twilio.com` or `lookups.twilio.com'.
"""

def __init__(self, twilio):
"""
:param Twilio twilio:
Expand All @@ -30,7 +31,7 @@ def request(self, method, uri, params=None, data=None, headers=None,
:param object data: The request body.
:param dict headers: The HTTP headers.
:param tuple auth: Basic auth tuple of (username, password)
:param int timeout: The request timeout.
:param float timeout: The request timeout.
:param bool allow_redirects: True if the client should follow HTTP
redirects.
"""
Expand Down
4 changes: 2 additions & 2 deletions twilio/http/http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ def __init__(self, pool_connections=True, request_hooks=None, timeout=None, logg

:param bool pool_connections
:param request_hooks
:param int timeout: Timeout for the requests.
Timeout should never be zero (0) or less.
:param float timeout: Timeout for the requests.
Timeout should never be zero (0) or less.
:param logger
:param dict proxy: Http proxy for the requests session
:param int max_retries: Maximum number of retries each request should attempt
Expand Down