Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support required resource properties with names containing periods #733

Merged
merged 1 commit into from Jan 27, 2022
Merged

feat: support required resource properties with names containing periods #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 4 additions & 1 deletion .jshintrc
View file
Open in desktop
Expand Up @@ -61,5 +61,8 @@
*/

// Suppress warnings about == null comparisons.
"eqnull": true
"eqnull": true,

// Supress errors regarding the use of bracket notation over dot notation
"sub": true
}
4 changes: 2 additions & 2 deletions lib/rest/accounts/v1/credential/aws.js
View file
Open in desktop
Expand Up @@ -316,8 +316,8 @@ AwsList = function AwsList(version) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.credentials)) {
throw new Error('Required parameter "opts.credentials" missing.');
if (_.isUndefined(opts['credentials'])) {
throw new Error('Required parameter "opts[\'credentials\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/accounts/v1/credential/publicKey.js
View file
Open in desktop
Expand Up @@ -315,8 +315,8 @@ PublicKeyList = function PublicKeyList(version) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.publicKey)) {
throw new Error('Required parameter "opts.publicKey" missing.');
if (_.isUndefined(opts['publicKey'])) {
throw new Error('Required parameter "opts[\'publicKey\']" missing.');
}

var deferred = Q.defer();
Expand Down
24 changes: 12 additions & 12 deletions lib/rest/api/v2010/account/address.js
View file
Open in desktop
Expand Up @@ -83,23 +83,23 @@ AddressList = function AddressList(version, accountSid) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.customerName)) {
throw new Error('Required parameter "opts.customerName" missing.');
if (_.isUndefined(opts['customerName'])) {
throw new Error('Required parameter "opts[\'customerName\']" missing.');
}
if (_.isUndefined(opts.street)) {
throw new Error('Required parameter "opts.street" missing.');
if (_.isUndefined(opts['street'])) {
throw new Error('Required parameter "opts[\'street\']" missing.');
}
if (_.isUndefined(opts.city)) {
throw new Error('Required parameter "opts.city" missing.');
if (_.isUndefined(opts['city'])) {
throw new Error('Required parameter "opts[\'city\']" missing.');
}
if (_.isUndefined(opts.region)) {
throw new Error('Required parameter "opts.region" missing.');
if (_.isUndefined(opts['region'])) {
throw new Error('Required parameter "opts[\'region\']" missing.');
}
if (_.isUndefined(opts.postalCode)) {
throw new Error('Required parameter "opts.postalCode" missing.');
if (_.isUndefined(opts['postalCode'])) {
throw new Error('Required parameter "opts[\'postalCode\']" missing.');
}
if (_.isUndefined(opts.isoCountry)) {
throw new Error('Required parameter "opts.isoCountry" missing.');
if (_.isUndefined(opts['isoCountry'])) {
throw new Error('Required parameter "opts[\'isoCountry\']" missing.');
}

var deferred = Q.defer();
Expand Down
8 changes: 4 additions & 4 deletions lib/rest/api/v2010/account/call.js
View file
Open in desktop
Expand Up @@ -137,11 +137,11 @@ CallList = function CallList(version, accountSid) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.to)) {
throw new Error('Required parameter "opts.to" missing.');
if (_.isUndefined(opts['to'])) {
throw new Error('Required parameter "opts[\'to\']" missing.');
}
if (_.isUndefined(opts.from)) {
throw new Error('Required parameter "opts.from" missing.');
if (_.isUndefined(opts['from'])) {
throw new Error('Required parameter "opts[\'from\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/call/feedback.js
View file
Open in desktop
Expand Up @@ -367,8 +367,8 @@ FeedbackContext.prototype.create = function create(opts, callback) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.qualityScore)) {
throw new Error('Required parameter "opts.qualityScore" missing.');
if (_.isUndefined(opts['qualityScore'])) {
throw new Error('Required parameter "opts[\'qualityScore\']" missing.');
}

var deferred = Q.defer();
Expand Down
8 changes: 4 additions & 4 deletions lib/rest/api/v2010/account/call/feedbackSummary.js
View file
Open in desktop
Expand Up @@ -78,11 +78,11 @@ FeedbackSummaryList = function FeedbackSummaryList(version, accountSid) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.startDate)) {
throw new Error('Required parameter "opts.startDate" missing.');
if (_.isUndefined(opts['startDate'])) {
throw new Error('Required parameter "opts[\'startDate\']" missing.');
}
if (_.isUndefined(opts.endDate)) {
throw new Error('Required parameter "opts.endDate" missing.');
if (_.isUndefined(opts['endDate'])) {
throw new Error('Required parameter "opts[\'endDate\']" missing.');
}

var deferred = Q.defer();
Expand Down
16 changes: 8 additions & 8 deletions lib/rest/api/v2010/account/call/payment.js
View file
Open in desktop
Expand Up @@ -107,11 +107,11 @@ PaymentList = function PaymentList(version, accountSid, callSid) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.idempotencyKey)) {
throw new Error('Required parameter "opts.idempotencyKey" missing.');
if (_.isUndefined(opts['idempotencyKey'])) {
throw new Error('Required parameter "opts[\'idempotencyKey\']" missing.');
}
if (_.isUndefined(opts.statusCallback)) {
throw new Error('Required parameter "opts.statusCallback" missing.');
if (_.isUndefined(opts['statusCallback'])) {
throw new Error('Required parameter "opts[\'statusCallback\']" missing.');
}

var deferred = Q.defer();
Expand Down Expand Up @@ -431,11 +431,11 @@ PaymentContext.prototype.update = function update(opts, callback) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.idempotencyKey)) {
throw new Error('Required parameter "opts.idempotencyKey" missing.');
if (_.isUndefined(opts['idempotencyKey'])) {
throw new Error('Required parameter "opts[\'idempotencyKey\']" missing.');
}
if (_.isUndefined(opts.statusCallback)) {
throw new Error('Required parameter "opts.statusCallback" missing.');
if (_.isUndefined(opts['statusCallback'])) {
throw new Error('Required parameter "opts[\'statusCallback\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/call/recording.js
View file
Open in desktop
Expand Up @@ -694,8 +694,8 @@ RecordingContext.prototype.update = function update(opts, callback) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.status)) {
throw new Error('Required parameter "opts.status" missing.');
if (_.isUndefined(opts['status'])) {
throw new Error('Required parameter "opts[\'status\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/call/siprec.js
View file
Open in desktop
Expand Up @@ -754,8 +754,8 @@ SiprecContext.prototype.update = function update(opts, callback) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.status)) {
throw new Error('Required parameter "opts.status" missing.');
if (_.isUndefined(opts['status'])) {
throw new Error('Required parameter "opts[\'status\']" missing.');
}

var deferred = Q.defer();
Expand Down
8 changes: 4 additions & 4 deletions lib/rest/api/v2010/account/conference/participant.js
View file
Open in desktop
Expand Up @@ -140,11 +140,11 @@ ParticipantList = function ParticipantList(version, accountSid, conferenceSid) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.from)) {
throw new Error('Required parameter "opts.from" missing.');
if (_.isUndefined(opts['from'])) {
throw new Error('Required parameter "opts[\'from\']" missing.');
}
if (_.isUndefined(opts.to)) {
throw new Error('Required parameter "opts.to" missing.');
if (_.isUndefined(opts['to'])) {
throw new Error('Required parameter "opts[\'to\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/conference/recording.js
View file
Open in desktop
Expand Up @@ -634,8 +634,8 @@ RecordingContext.prototype.update = function update(opts, callback) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.status)) {
throw new Error('Required parameter "opts.status" missing.');
if (_.isUndefined(opts['status'])) {
throw new Error('Required parameter "opts[\'status\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/incomingPhoneNumber/assignedAddOn.js
View file
Open in desktop
Expand Up @@ -322,8 +322,8 @@ AssignedAddOnList = function AssignedAddOnList(version, accountSid, resourceSid)
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.installedAddOnSid)) {
throw new Error('Required parameter "opts.installedAddOnSid" missing.');
if (_.isUndefined(opts['installedAddOnSid'])) {
throw new Error('Required parameter "opts[\'installedAddOnSid\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/incomingPhoneNumber/local.js
View file
Open in desktop
Expand Up @@ -377,8 +377,8 @@ LocalList = function LocalList(version, accountSid) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.phoneNumber)) {
throw new Error('Required parameter "opts.phoneNumber" missing.');
if (_.isUndefined(opts['phoneNumber'])) {
throw new Error('Required parameter "opts[\'phoneNumber\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/incomingPhoneNumber/mobile.js
View file
Open in desktop
Expand Up @@ -377,8 +377,8 @@ MobileList = function MobileList(version, accountSid) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.phoneNumber)) {
throw new Error('Required parameter "opts.phoneNumber" missing.');
if (_.isUndefined(opts['phoneNumber'])) {
throw new Error('Required parameter "opts[\'phoneNumber\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/incomingPhoneNumber/tollFree.js
View file
Open in desktop
Expand Up @@ -377,8 +377,8 @@ TollFreeList = function TollFreeList(version, accountSid) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.phoneNumber)) {
throw new Error('Required parameter "opts.phoneNumber" missing.');
if (_.isUndefined(opts['phoneNumber'])) {
throw new Error('Required parameter "opts[\'phoneNumber\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/message.js
View file
Open in desktop
Expand Up @@ -105,8 +105,8 @@ MessageList = function MessageList(version, accountSid) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.to)) {
throw new Error('Required parameter "opts.to" missing.');
if (_.isUndefined(opts['to'])) {
throw new Error('Required parameter "opts[\'to\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/queue.js
View file
Open in desktop
Expand Up @@ -315,8 +315,8 @@ QueueList = function QueueList(version, accountSid) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.friendlyName)) {
throw new Error('Required parameter "opts.friendlyName" missing.');
if (_.isUndefined(opts['friendlyName'])) {
throw new Error('Required parameter "opts[\'friendlyName\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/queue/member.js
View file
Open in desktop
Expand Up @@ -601,8 +601,8 @@ MemberContext.prototype.update = function update(opts, callback) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.url)) {
throw new Error('Required parameter "opts.url" missing.');
if (_.isUndefined(opts['url'])) {
throw new Error('Required parameter "opts[\'url\']" missing.');
}

var deferred = Q.defer();
Expand Down
8 changes: 4 additions & 4 deletions lib/rest/api/v2010/account/sip/credentialList.js
View file
Open in desktop
Expand Up @@ -315,8 +315,8 @@ CredentialListList = function CredentialListList(version, accountSid) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.friendlyName)) {
throw new Error('Required parameter "opts.friendlyName" missing.');
if (_.isUndefined(opts['friendlyName'])) {
throw new Error('Required parameter "opts[\'friendlyName\']" missing.');
}

var deferred = Q.defer();
Expand Down Expand Up @@ -674,8 +674,8 @@ CredentialListContext.prototype.update = function update(opts, callback) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.friendlyName)) {
throw new Error('Required parameter "opts.friendlyName" missing.');
if (_.isUndefined(opts['friendlyName'])) {
throw new Error('Required parameter "opts[\'friendlyName\']" missing.');
}

var deferred = Q.defer();
Expand Down
8 changes: 4 additions & 4 deletions lib/rest/api/v2010/account/sip/credentialList/credential.js
View file
Open in desktop
Expand Up @@ -319,11 +319,11 @@ CredentialList = function CredentialList(version, accountSid, credentialListSid)
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.username)) {
throw new Error('Required parameter "opts.username" missing.');
if (_.isUndefined(opts['username'])) {
throw new Error('Required parameter "opts[\'username\']" missing.');
}
if (_.isUndefined(opts.password)) {
throw new Error('Required parameter "opts.password" missing.');
if (_.isUndefined(opts['password'])) {
throw new Error('Required parameter "opts[\'password\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/sip/domain.js
View file
Open in desktop
Expand Up @@ -340,8 +340,8 @@ DomainList = function DomainList(version, accountSid) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.domainName)) {
throw new Error('Required parameter "opts.domainName" missing.');
if (_.isUndefined(opts['domainName'])) {
throw new Error('Required parameter "opts[\'domainName\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions ...api/v2010/account/sip/domain/authTypes/authCallsMapping/authCallsCredentialListMapping.js
View file
Open in desktop
Expand Up @@ -78,8 +78,8 @@ AuthCallsCredentialListMappingList = function
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.credentialListSid)) {
throw new Error('Required parameter "opts.credentialListSid" missing.');
if (_.isUndefined(opts['credentialListSid'])) {
throw new Error('Required parameter "opts[\'credentialListSid\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions ...2010/account/sip/domain/authTypes/authCallsMapping/authCallsIpAccessControlListMapping.js
View file
Open in desktop
Expand Up @@ -78,8 +78,8 @@ AuthCallsIpAccessControlListMappingList = function
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.ipAccessControlListSid)) {
throw new Error('Required parameter "opts.ipAccessControlListSid" missing.');
if (_.isUndefined(opts['ipAccessControlListSid'])) {
throw new Error('Required parameter "opts[\'ipAccessControlListSid\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions ...t/sip/domain/authTypes/authRegistrationsMapping/authRegistrationsCredentialListMapping.js
View file
Open in desktop
Expand Up @@ -78,8 +78,8 @@ AuthRegistrationsCredentialListMappingList = function
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.credentialListSid)) {
throw new Error('Required parameter "opts.credentialListSid" missing.');
if (_.isUndefined(opts['credentialListSid'])) {
throw new Error('Required parameter "opts[\'credentialListSid\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/sip/domain/credentialListMapping.js
View file
Open in desktop
Expand Up @@ -74,8 +74,8 @@ CredentialListMappingList = function CredentialListMappingList(version,
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.credentialListSid)) {
throw new Error('Required parameter "opts.credentialListSid" missing.');
if (_.isUndefined(opts['credentialListSid'])) {
throw new Error('Required parameter "opts[\'credentialListSid\']" missing.');
}

var deferred = Q.defer();
Expand Down
4 changes: 2 additions & 2 deletions lib/rest/api/v2010/account/sip/domain/ipAccessControlListMapping.js
View file
Open in desktop
Expand Up @@ -75,8 +75,8 @@ IpAccessControlListMappingList = function
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.ipAccessControlListSid)) {
throw new Error('Required parameter "opts.ipAccessControlListSid" missing.');
if (_.isUndefined(opts['ipAccessControlListSid'])) {
throw new Error('Required parameter "opts[\'ipAccessControlListSid\']" missing.');
}

var deferred = Q.defer();
Expand Down
8 changes: 4 additions & 4 deletions lib/rest/api/v2010/account/sip/ipAccessControlList.js
View file
Open in desktop
Expand Up @@ -319,8 +319,8 @@ IpAccessControlListList = function IpAccessControlListList(version, accountSid)
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.friendlyName)) {
throw new Error('Required parameter "opts.friendlyName" missing.');
if (_.isUndefined(opts['friendlyName'])) {
throw new Error('Required parameter "opts[\'friendlyName\']" missing.');
}

var deferred = Q.defer();
Expand Down Expand Up @@ -680,8 +680,8 @@ IpAccessControlListContext.prototype.update = function update(opts, callback) {
if (_.isUndefined(opts)) {
throw new Error('Required parameter "opts" missing.');
}
if (_.isUndefined(opts.friendlyName)) {
throw new Error('Required parameter "opts.friendlyName" missing.');
if (_.isUndefined(opts['friendlyName'])) {
throw new Error('Required parameter "opts[\'friendlyName\']" missing.');
}

var deferred = Q.defer();
Expand Down