feat(tabs): make non-fitted tabs responsive #3857
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 19498cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 19498cd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
|
Size Change: +1.2 kB (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
dosubot
bot
added
size:L
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 19498cd:
|
Passing run #7970 ↗︎
Details:
Review all test suite changes for PR #3857 ↗︎ |
|||||||||||||||
serifluous
reviewed
Apr 11, 2024
TheSisb
force-pushed
the
tabs/responsive
branch
from
b11e7bd
to
98d431f
Compare
dosubot
bot
added
size:XL
|
This is blocked on an accessiblity issue where my solution added wrappers for the scrollbar around the individual tabs and the tab wrapper. The tabs need to be direct children of the tab wrapper, and it is causing screenreaders to not correctly link the two elements together. A solution would be to use aria- tags to connect them, but I didn't have great success with it in my preliminary tests. This requires more experimentation. Another solution would be to move my wrappers outside the tabWrapper rather than between it and the tabs, and then update the styling accordingly to make this solution work. I haven't explored this, and is just an idea. |
TheSisb
added
the
Status: Blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went to great lengths to use a native scrollbar solution and style it such that I wouldn't need a pure JS built scrollbar.
In order to achieve this, I needed to add two wrapper divs to the TabList component. One for the outer scrollbar, and one for the bottom border. I still need some JS to fetch the total width of the TabList in order to position the bottom border correctly cross-browser, and to offset the scrollbar position by 4px on the outside of the element visually.
I also made the Tabs component scroll to the selected tab on mount, if it is off-screen. This initial scroll happens instantly to avoid screen noise. Subsequent tab navigation will smoothly scroll to the selected tab to provide a more refined experience.
Fitted tabs do not receive any significant changes, as by definition they shouldn't overflow or scroll.
Vertical tabs have similarly remained untouched.
I tested these changes thoroughly on Safari, Firefox, and Chrome, and checked the browser support tables for the features I'm using to verify they pass our requirements.
Chrome
Firefox
Safari