feat: better assistant response error handling #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
|
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Type: Documentation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7ba1602. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7ba1602:
|
TheSisb
previously approved these changes
Feb 23, 2024
|
Size Change: 0 B Total Size: 1.02 MB ℹ️ View Unchanged
|
Passing run #7895 ↗︎
Details:
Review all test suite changes for PR #3793 ↗︎ |
|||||||||||||||
dosubot
bot
added
the
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the error handling and response processing in the
paste-websitepackage. The changes mainly focus on two areas: refining the fetch API calls inassistantAPIs.tsand enhancing error handling in various components.The most important changes are:
Refactoring fetch API calls in
assistantAPIs.tsto handle responses and errors more effectively. The changes include awaiting the fetch response, converting it to JSON, and throwing an error if the response is not ok. This is applied to all the mutation functions:useCreateThreadMutation,useDeleteThreadMutation,useUpdateThreadMutation,useCreateAssistantRunMutation, anduseSimpleCompletionMutation. [1] [2] [3] [4] [5]Introducing the
AssistantToastercomponent and context to handle and display errors in a user-friendly way. TheAssistantToasteris used across multiple components likeAssistant.tsx,AssistantCanvas.tsx,AssistantMessagePoller.ts,AssistantThreads.tsx,AsststantHeader.tsxto handle errors during various operations like creating a thread, deleting a thread, fetching messages, etc. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Improvements in the
AssistantComposercomponent inAssistantComposer.tsxto handle the case when theselectedThreadisnull. TheSendButtonPluginis also updated to handle thedisabledprop as optional. [1] [2]Adding content moderation to the message handler in
paste-assistant-message.ts. The moderation is done using OpenAI's moderation API, and an error is thrown if the message content is flagged.Minor changes include updating the
SendButtonPlugininSendButtonPlugin.tsxto handle thedisabledprop as optional.