Move some static extension methods to non-static #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
commented
Apr 19, 2024
| { | ||
| if (null === $format) { | ||
| $formats = $env->getExtension(self::class)->getDateFormat(); | ||
| $formats = $this->getDateFormat(); |
There was a problem hiding this comment.
The main idea is to remove the usage of $env when possible so that we can extract these methods to another class that would be available for public consumption.
fabpot
changed the title
stof
reviewed
Apr 19, 2024
fabpot
force-pushed
the
less-static-methods
branch
5 times, most recently
from
2920b39
to
b2433c3
Compare
fabpot
changed the title
fabpot
force-pushed
the
less-static-methods
branch
2 times, most recently
from
fbcc8cb
to
c654232
Compare
fabpot
force-pushed
the
less-static-methods
branch
from
c654232
to
283475b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first step to resolve #4040