Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html-extra] rename html_classes() to html_attr() #3970

Closed
wants to merge 1 commit into from

Conversation

kbond
Copy link
Contributor

@kbond kbond commented Jan 23, 2024

This function can be used for any html attribute (ie data-action, data-controller).

@kbond
Copy link
Contributor Author

kbond commented Jan 23, 2024

If acceptable, I'll update the docs.

@stof
Copy link
Member

stof commented Jan 23, 2024

it can be used for attributes containing a space-separated list. That's not for any attribute out there. So html_attr is too generic for what it does (thus, using the same name than the html_attr escaping strategy can cause confusion)

@kbond
Copy link
Contributor Author

kbond commented Jan 23, 2024

That's fair, maybe html_join or html_attr_join? But we'd have to configure the separator which I think would be hard (maybe not worth it).

@fabpot
Copy link
Contributor

fabpot commented Feb 10, 2024

If we were to rename to function, html_attr_join sounds good to me.

@fabpot
Copy link
Contributor

fabpot commented Apr 29, 2024

@kbond If you're ok with the new name, can you update this PR?

Copy link
Contributor

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note in the main CHANGELOG file and in doc/deprecated.rst?

@kbond
Copy link
Contributor Author

kbond commented Apr 30, 2024

I'm going to close this for now. I'm now feeling it's not worth the change.

@kbond kbond closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants