[html-extra] filter classes #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
force-pushed
the
feat/html-classes-improvements
branch
from
0716779
to
2dbc861
Compare
stof
reviewed
Jan 23, 2024
kbond
force-pushed
the
feat/html-classes-improvements
branch
from
2dbc861
to
b08181e
Compare
fabpot
approved these changes
Apr 29, 2024
extra/html-extra/HtmlExtension.php
Outdated
| @@ -75,7 +75,7 @@ public function dataUri(string $data, string $mime = null, array $parameters = [ | |||
| $repr .= ';'.$key.'='.rawurlencode($value); | |||
| } | |||
|
|
|||
| if (0 === strpos($mime, 'text/')) { | |||
| if (str_starts_with($mime, 'text/')) { | |||
fabpot
force-pushed
the
feat/html-classes-improvements
branch
from
b08181e
to
a517c14
Compare
|
Thank you @kbond. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small formatting change to avoid double spaces:
class="{{ html_classes('a', false ? 'b', true ? 'c') }}" {# before #} class="a c" {# after #} class="a c"