[templates] add shuffle filter #3966
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jan 19, 2024
Sarah-eit
force-pushed
the
feat/add-shuffle-filter
branch
from
21a8260
to
3e94978
Compare
xabbuh
reviewed
Jan 19, 2024
Sarah-eit
force-pushed
the
feat/add-shuffle-filter
branch
from
e7a0e6a
to
e26a4e8
Compare
GromNaN
approved these changes
Feb 8, 2024
smnandre
reviewed
Feb 10, 2024
Sarah-eit
force-pushed
the
feat/add-shuffle-filter
branch
from
992dc6d
to
09b6bcf
Compare
fabpot
requested changes
May 1, 2024
| 2 | ||
| 6 | ||
| 3 | ||
| 3 |
There was a problem hiding this comment.
These tests don't really test anything, right?
| @@ -222,6 +222,7 @@ public function getFilters(): array | |||
|
|
|||
| // string/array filters | |||
| new TwigFilter('reverse', [self::class, 'reverseFilter'], ['needs_environment' => true]), | |||
| new TwigFilter('shuffle', [self::class, 'shuffleFilter'], ['needs_environment' => true]), | |||
There was a problem hiding this comment.
Suggested change
| new TwigFilter('shuffle', [self::class, 'shuffleFilter'], ['needs_environment' => true]), | |
| new TwigFilter('shuffle', [self::class, 'shuffleFilter'], ['needs_charset' => true]), |
| * | ||
| * @internal | ||
| */ | ||
| public static function shuffleFilter(Environment $env, mixed $item): mixed |
There was a problem hiding this comment.
Suggested change
| public static function shuffleFilter(Environment $env, mixed $item): mixed | |
| public static function shuffleFilter(string $charset $item): mixed |
For $item, we can be more precise than mixed o the phpdocs.
| public static function shuffleFilter(Environment $env, mixed $item): mixed | ||
| { | ||
| if (\is_string($item)) { | ||
| $charset = $env->getCharset(); |
| @@ -920,6 +921,38 @@ public static function reverseFilter(Environment $env, $item, $preserveKeys = fa | |||
| return $string; | |||
| } | |||
|
|
|||
| /** | |||
| * Shuffle an array, a \Traversable instance, or a string. | |||
There was a problem hiding this comment.
Suggested change
| * Shuffle an array, a \Traversable instance, or a string. | |
| * Shuffles an array, a \Traversable instance, or a string. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature :
The filter displays the values in an array at random.
I'm open of any feedback.