IntlExtension > Return empty string when input is null #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
changed the title
ruudk
force-pushed
the
return-empty-string-on-null-input
branch
from
d52e3c9
to
f3c4595
Compare
fabpot
force-pushed
the
return-empty-string-on-null-input
branch
from
f3c4595
to
caecd2a
Compare
|
Thank you @ruudk. |
fabpot
added a commit
that referenced
this pull request
Feb 13, 2020
This PR was submitted for the 3.x branch but it was merged into the 2.x branch instead.
Discussion
----------
IntlExtension > Return empty string when input is null
```twig
{{ inputCountry | country_name('en') }}
```
When `inputCountry` is `null` it will give this error:
```
Argument 1 passed to Twig\Extra\Intl\IntlExtension::getCountryName() must be of the type string, null given
```
With this change, an empty string will be returned instead.
See discussion in #3257 (comment)
Commits
-------
caecd2a IntlExtension > Return empty string when input is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{ inputCountry | country_name('en') }}When
inputCountryisnullit will give this error:With this change, an empty string will be returned instead.
See discussion in #3257 (comment)