Deprecate CoreExtension::setEscaper() and CoreExtension::getEscaper() in favor of the same methods on EscaperExtension #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
commented
May 21, 2019
|
|
||
| if (null === $escapers) { | ||
| // merge the ones set on CoreExtension for BC (to be removed in 3.0) | ||
| $escapers = array_merge( |
There was a problem hiding this comment.
This is where we deal with BC.
…) in favor of the same methods on EscaperExtension
fabpot
added a commit
that referenced
this pull request
May 21, 2019
…::getEscaper() in favor of the same methods on EscaperExtension (fabpot) This PR was merged into the 2.x branch. Discussion ---------- Deprecate CoreExtension::setEscaper() and CoreExtension::getEscaper() in favor of the same methods on EscaperExtension This is some preliminary work to ease #3025. Everything related to escaping is now part of the `EscaperExtension` instead of `CoreExtension`. This PR is submitted on 2.x because both extensions are always available in 2.x (which is not the case on 1.x). Commits ------- 59d1d5d deprecated CoreExtension::setEscaper() and CoreExtension::getEscaper() in favor of the same methods on EscaperExtension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some preliminary work to ease #3025. Everything related to escaping is now part of the
EscaperExtensioninstead ofCoreExtension. This PR is submitted on 2.x because both extensions are always available in 2.x (which is not the case on 1.x).