Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitattributes to exclude non-dist files #3570

Merged
merged 1 commit into from Oct 4, 2021

Conversation

kaznovac
Copy link
Contributor

@kaznovac kaznovac commented Oct 2, 2021

resolves #3503

some extra files can be excluded also:

  • changelog
  • license
  • readme

should this be rebased to 1.x, 2.x?

@stof
Copy link
Member

stof commented Oct 4, 2021

The license file definitely cannot be excluded.

@fabpot
Copy link
Contributor

fabpot commented Oct 4, 2021

I don't see the point. These files are do not contribute significantly to the size of the archive and as mentioned by stof, some cannot be removed. Let's close. Thank you for proposing.

@fabpot fabpot closed this Oct 4, 2021
@kaznovac
Copy link
Contributor Author

kaznovac commented Oct 4, 2021

@fabpot

let me cite @stof

excluding the doc source code from the archive indeed probably makes sense (that's probably the bulk of these 640KB as others are small files)
#3503 (comment)

and this pr excludes the doc, along with the git and github speciffic configs

@fabpot
Copy link
Contributor

fabpot commented Oct 4, 2021

@fabpot Sorry, can you update this PR to "just" exclude the doc/ directory in addition to what we already have?

@fabpot fabpot reopened this Oct 4, 2021
@kaznovac
Copy link
Contributor Author

kaznovac commented Oct 4, 2021

@fabpot np :), excluded "just" doc/ (in the same manner as /extra/**)

@fabpot fabpot changed the base branch from 3.x to 1.x October 4, 2021 09:03
@fabpot
Copy link
Contributor

fabpot commented Oct 4, 2021

Thank you @kaznovac.

@fabpot fabpot merged commit 8bab813 into twigphp:1.x Oct 4, 2021
@kaznovac kaznovac deleted the patch-1 branch October 5, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Optimize for packagist production
3 participants